Skip to content

[arellano] Update lecture to latest style guide#271

Merged
jstac merged 4 commits into
mainfrom
arellano_update
Jul 13, 2026
Merged

[arellano] Update lecture to latest style guide#271
jstac merged 4 commits into
mainfrom
arellano_update

Conversation

@kp992

@kp992 kp992 commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

This PR:

  • Updates the JAX code and does minor updates to styling.
  • fixes minor typos.

@netlify

netlify Bot commented Dec 8, 2025

Copy link
Copy Markdown

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit 3c3259e
🔍 Latest deploy log https://app.netlify.com/projects/incomparable-parfait-2417f8/deploys/6936c5f1d194cf00080acbd7
😎 Deploy Preview https://deploy-preview-271--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request December 8, 2025 12:42 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request December 8, 2025 12:45 Inactive
@kp992
kp992 requested a review from mmcky December 13, 2025 06:11
@netlify

netlify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit cae4b89
🔍 Latest deploy log https://app.netlify.com/projects/incomparable-parfait-2417f8/deploys/6a55497059433700086d0251
😎 Deploy Preview https://deploy-preview-271--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2026 21:06 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2026 21:11 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request July 13, 2026 20:31 Inactive
@jstac

jstac commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

CC @mmcky — flagging a preview-deploy issue on this PR that looks like a build-system problem rather than anything in the content.

Symptom: the "Deploy Preview" link that the Netlify GitHub app advertises 404s:

But the build actually succeeded and is live — just under the permalink, not the alias:

The latest CI run for arellano_update (commit cae4b89) completed successfully, and GitHub's deployment API maps that run's deploy to the permalink above (ref cae4b891…, state success, 2026-07-13).

Likely cause: this repo runs two Netlify integrations in parallel:

  1. The official Netlify GitHub app, which owns the deploy-preview-271--… alias and posts the "✅ Deploy Preview ready" comment.
  2. The nwtgck/actions-netlify step in .github/workflows/ci.yml, which publishes from _build/html/ and posts the 🚀 Deployed on <permalink> comment.

The actions-netlify step is publishing a working build (hence the live permalink), but the deploy-preview-271 alias the Netlify app comment points at is detached from that build — so the link everyone clicks 404s while the content is actually up. Having both integrations deploy to the same site is probably the root of the collision.

Could you take a look at the build system when you get a chance? The fix is likely either dropping one of the two integrations or making sure the alias is bound to the actions-netlify deploy. Happy to help test.

@jstac

jstac commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@kp992 Many thanks! All looks good. I'll merge now.

@mmcky A comment above from Claude about issues with finding the live deployment. I'm not sure if it's worth fixing before the switch one the monorepo. I guess it depends how we're going to handle existing PRs.

@jstac
jstac merged commit b75b867 into main Jul 13, 2026
7 checks passed
@jstac
jstac deleted the arellano_update branch July 13, 2026 20:57
@kp992

kp992 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for merging this @jstac

@mmcky

mmcky commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@jstac spot-on diagnosis, thanks for tracking that down. It was exactly the two-integration collision you described — the official Netlify GitHub app owned the deploy-preview-271 alias and its comment, while the nwtgck/actions-netlify step published the actual working build under a detached permalink.

Fixed in #336 (merged):

  • Migrated the preview step to the org-standard quantecon/actions/preview-netlify@v0.8.0 (same as lecture-python.myst). It deploys via the Netlify CLI to a deterministic pr-<N> alias and posts a single self-updating comment with direct links to the changed lecture pages, so the link in the comment is always the one bound to the build.
  • Removed the redundant Netlify deploy from collab.yml — a second actions-netlify step that was racing the same site/alias and publishing a lesser build (no notebook/PDF assets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants